docs: update command for running the single binary #6031
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Future-Outlier
approved these changes
Nov 19, 2024
./flyte file is move to $GOPATH/bin by `make compile`, run flyte instead of ./flyte Signed-off-by: machichima <[email protected]>
machichima
force-pushed
the
update-run-single-binary-command
branch
from
3951669
to
b96aefa
Compare
Future-Outlier
approved these changes
Nov 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6031 +/- ##
==========================================
- Coverage 37.05% 37.05% -0.01%
==========================================
Files 1316 1316
Lines 132100 132100
==========================================
- Hits 48952 48949 -3
- Misses 78895 78897 +2
- Partials 4253 4254 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Congrats on merging your first pull request! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
Following the instruction of setting up environment, the command
POD_NAMESPACE=flyte ./flyte start --config flyte-single-binary-local.yamlgives errorno such file or directory: ./flyteIt turns out that
make compilecommand move./flytefile to$GOPATH/bin. Hence, directly runflyteinstead of./flyteworks.What changes were proposed in this pull request?
change
./flytein command toflyteHow was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link